Pass reportActions as param to shouldShowReportActionNotification by bernhardoj · Pull Request #95318 · Expensify/App

bernhardoj · 2026-07-04T08:12:44Z

Explanation of Change

Fixed Issues

$ #73651
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

User A has a one-single expense report

Open the one-single expense report as User A
As User B, open the transaction thread (you can invite the user by mentioning them on the report)
As User B, send a message on the transaction thread
While the report is open as User A, verify no notification appears

NOTE: if you open both users on the same device (even with different tab/browser), on step 4, make sure the User A tab is open and focused (you can click into the app to make it focus)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

w.mp4

melvin-bot · 2026-07-04T08:12:49Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-07-04T08:12:54Z

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

…seonyx-8

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e9cb8fc2e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-05T07:21:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useOneTransactionThreadReportID.tsx	`100.00% <100.00%> (ø)`
src/libs/actions/User.ts	`35.59% <100.00%> (ø)`
src/libs/actions/Report/index.ts	`70.09% <66.66%> (-0.42%)`	⬇️
...Navigation/AppNavigator/AuthScreensInitHandler.tsx	`88.00% <75.00%> (-1.71%)`	⬇️
...ion/PushNotification/shouldShowPushNotification.ts	`30.76% <40.00%> (+7.23%)`	⬆️
... and 275 files with indirect coverage changes

mountiny · 2026-07-05T16:40:29Z

    const reportAttributesRef = useRef(reportAttributes);
    reportAttributesRef.current = reportAttributes;

+    const [reportActions] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS);


I am actually not sure about this one, the component does render null but still adding the largest collection useOnyx will execute this path often. So I wonder if the connectWithoutView wouldnt actually be better here 🤔 @tgolen @luacmartins @bernhardoj

Well, it looks to me like it's only using the report actions of a single report (eg. from const topmostReportID = Navigation.getTopmostReportId();), and it's only trying to get the getOneTransactionThreadReportAction() for that report.

I would prefer at least using a selector here to only subscribe to one report's actions, instead of the entire collection.

It would be even better if there was a hook or a selector (I am pretty sure there might be already) that returns the one-transaction-thread-report-action

I do agree with you though that we should be very careful of adding a subscription this large to a top-level navigator. I don't know what kind of performance impact that would have.

Done. Now we pass the one-transaction report ID only.

It would be even better if there was a hook or a selector (I am pretty sure there might be already)

I don't see one, so I created the hook.

tgolen · 2026-07-05T21:13:18Z

 });

+let allReportActions: OnyxCollection<ReportActions>;
+Onyx.connectWithoutView({


Add a comment to indicate why it's OK to use this instead of using useOnyx()

I reuse the comment from the above one

// We do not depend on updates on the UI for notifications, so we can use connectWithoutView here.

OK, that comment is a little confusing. How about this?

Push notifications aren't rendered using React, so it's impossible to access Onyx data with useOnyx(), therefore, it's OK to use connectWithoutView() here.

tgolen · 2026-07-05T21:19:54Z

    const reportAttributesRef = useRef(reportAttributes);
    reportAttributesRef.current = reportAttributes;

+    const [reportActions] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS);


Well, it looks to me like it's only using the report actions of a single report (eg. from const topmostReportID = Navigation.getTopmostReportId();), and it's only trying to get the getOneTransactionThreadReportAction() for that report.

I would prefer at least using a selector here to only subscribe to one report's actions, instead of the entire collection.

It would be even better if there was a hook or a selector (I am pretty sure there might be already) that returns the one-transaction-thread-report-action

I do agree with you though that we should be very careful of adding a subscription this large to a top-level navigator. I don't know what kind of performance impact that would have.

JmillsExpensify

No product review required.

tgolen

I love the hook! Thats brilliant. Thanks!

tgolen · 2026-07-07T14:57:06Z

 });

+let allReportActions: OnyxCollection<ReportActions>;
+Onyx.connectWithoutView({


OK, that comment is a little confusing. How about this?

Push notifications aren't rendered using React, so it's impossible to access Onyx data with useOnyx(), therefore, it's OK to use connectWithoutView() here.

bernhardoj · 2026-07-07T15:53:32Z

Updated the comment and left only 1 comment because it's true for all connectWithoutView usage in that file

mountiny

@eVoloshchak Can you please review and test this PR?

eVoloshchak · 2026-07-07T18:40:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-07-08_15-16-30.mp4

Android: mWeb Chrome

Screen.Recording.2026-07-08.at.15.05.33.mov

iOS: HybridApp

Screen.Recording.2026-07-08.at.14.56.58.mov

iOS: mWeb Safari

Screen.Recording.2026-07-08.at.14.58.04.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-08.at.14.53.57.mov

eVoloshchak · 2026-07-08T05:14:34Z

Open the one-single expense report as User A
As User B, open the transaction thread (you can invite the user by mentioning them on the report)
As User B, send a message on the transaction thread
While the report is open as User A, verify no notification appears

@bernhardoj, this still shows the notification after step 4 for me (notice the tab sound icon, notifications are hidden when screen recording, but they're shown normally)

Screen.Recording.2026-07-08.at.07.12.16.mov

bernhardoj · 2026-07-08T06:56:51Z

While the report is open as User A

@eVoloshchak oh, I should be more specific, you need the tab to be focused (sometimes I even need to click into the app), otherwise Visibility.isVisible() && Visibility.hasFocus() will be false.

App/src/libs/actions/Report/index.ts

Lines 4613 to 4617 in 92303dd

    
           if ( 
        
               reportID === ReportActionsUtils.getOneTransactionThreadReportID(topmostReport, chatTopmostReport, topmostReportActions, isOfflineNetwork()) && 
        
               Visibility.isVisible() && 
        
               Visibility.hasFocus() 
        
           ) {

Added a note on the QA Steps

eVoloshchak

LGTM!

mountiny · 2026-07-08T14:20:02Z

I did not review but approvals are in and checks are green so I will merge now

github-actions · 2026-07-08T14:24:51Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-08T14:31:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-08T14:36:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95318.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-374dbdcc1d7-ee2dd9f-fe62a3b0bdfcf3a4f1694d87ced58ce9237f78b8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-374dbdc-ee2dd9f-f3d05acb0f666b450fc30a1f5f64d1d3a6dbd5dd/index.html

Web 🕸️
https://95318.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

bernhardoj added 2 commits July 2, 2026 22:52

pass reportActions as param to shouldShowReportActionNotification

0fac7d0

fix key

0e9cb8f

bernhardoj requested review from a team as code owners July 4, 2026 08:12

melvin-bot Bot assigned bernhardoj Jul 4, 2026

melvin-bot Bot requested review from JmillsExpensify and eVoloshchak July 4, 2026 08:12

melvin-bot Bot removed request for a team July 4, 2026 08:12

github-actions Bot requested review from luacmartins, mountiny and tgolen July 4, 2026 08:12

Merge branch 'main' into chore/73651-refactor-report-actions-to-use-u…

ec486e7

…seonyx-8

github-actions Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

github-actions Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx

chatgpt-codex-connector Bot reviewed Jul 4, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/AuthScreensInitHandler.tsx Outdated

fix test

3f1c61a

mountiny reviewed Jul 5, 2026

View reviewed changes

tgolen reviewed Jul 5, 2026

View reviewed changes

bernhardoj added 6 commits July 6, 2026 10:05

simplify by passing the one transaction thread report only

2da1626

add comment

e44f344

fix test

b43d920

add test

afe9bd1

pass the topmost one-transaction thread report id

59ef281

lint

f758014

JmillsExpensify reviewed Jul 7, 2026

View reviewed changes

tgolen requested changes Jul 7, 2026

View reviewed changes

update comment

1f4ce40

tgolen approved these changes Jul 7, 2026

View reviewed changes

mountiny approved these changes Jul 7, 2026

View reviewed changes

luacmartins approved these changes Jul 7, 2026

View reviewed changes

eVoloshchak approved these changes Jul 8, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins July 8, 2026 13:17

mountiny merged commit 374dbdc into Expensify:main Jul 8, 2026
35 of 38 checks passed

Uh oh!

Conversation

bernhardoj commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 4, 2026

Uh oh!

github-actions Bot commented Jul 4, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jul 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgolen Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jul 7, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Jul 8, 2026

Uh oh!

bernhardoj commented Jul 8, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jul 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 8, 2026

bernhardoj commented Jul 4, 2026 •

edited

Loading

codecov Bot commented Jul 5, 2026 •

edited by github-actions Bot

Loading

tgolen Jul 7, 2026 •

edited

Loading

tgolen Jul 7, 2026 •

edited

Loading

eVoloshchak commented Jul 7, 2026 •

edited

Loading